46

College Graduate joins the team, assigned the first jira story.
Perfect logic, variable naming can be improved, but I can let that go, since the logic was good.

Rejected the implementation in fisheye because she used
if()
{
//
}
Instead of
if(){
//
}

What's wrong with me...

Comments
  • 5
    You try to avoid bugs from random codingstyles.
  • 4
    Nothing.

    NO MORE UNNECESSARY EMPTY LINES!!!

    😈😈😈
  • 2
    Nothing, you're just doing God's work. Now hopefully she already uses tabs...
  • 4
    @Kaji nah she must be using tabs, thats why that kind of aesthetical aberration happened, and emacs i guess.

    Beign serious I like to follow lang community standards like when coding in java if go full if(){} but for c# i go

    If()
    {
    }

    but tbh the team preferences should always be taken into consideration
  • 0
    That's kinda mean :l
  • 1
    @Kaji are you kidding? The whole codebase of 3 repos are in spaces, that too, 2 spaces instead of usual 4.
Add Comment