Learn More
Resend Email
17
devphobe
3y

if ( condition ) {
callback(data)
}
callback(error)

--is a lot different than--

if ( condition ) {
callback(data)
} else {
callback(error)
}

callbacks are not return statements 🀦‍♂️

rant

typescript
Favorite
Ranter
Comments
  • 1
    3y
    I'm sick of seeing this.

    I mostly work with PL/SQL, and I cant count the times I see something like that.

    Or ifs checking if a error message is returned, but you have a exception catching that and exiting the function
  • 7
    3y
    What if the success statement throws a success exception?

    Checkmate atheists
  • 2
    3y
    @alexbrooklyn that would’ve saved me two hours of debugging. I’m okay with that today.
  • 1
    3y
    How about

    return callback(data)
  • 0
    3y
    @neel-basu that was the point of the rant :p
  • 0
    3y
    Callback && callback(data || error);

    How about that?
    Or use promises? :p
  • 0
    3y
    @bashleigh I'm stuck passing this callback function to a 3rd party library. I'm getting ready to just copy and paste the parts of the library I need into our own codebase and refactor it the right way.
  • 0
    3y
    @devphobe do it. I dare you πŸ˜‚πŸ˜‚
  • 0
    3y
    Oh really?
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment